-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass find_package(torch) for find_package_torch_headers to help out cross compilation #8629
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8629
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit ff128f7 with merge base 52a3a9a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
… cross compilation To be honest, I don't understand how the Android demo compiles currently. This should make it more robust, but I'm submitting this as a draft and will wait until I have a concrete need for this. ghstack-source-id: a984326e9f174405787f99ac1138afa710f8758e ghstack-comment-id: 2675755240 Pull Request resolved: #8629
This PR needs a
|
error message I was getting for posterity:
|
To be honest, I don't understand how the Android demo compiles currently. Indeed, it doesn't work on my Mac without this change, but with this change it does.
Should fix #8556