Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shim/xplat to shim_et/xplat, try 2 #8607

Open
wants to merge 1 commit into
base: gh/swolchok/275/base
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 21, 2025

Stack from ghstack (oldest at bottom):

Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927.

Differential Revision: D69955361

Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927.

Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8607

Note: Links to docs will display an error until the docs builds have been completed.

❌ 36 New Failures, 1 Unrelated Failure

As of commit 6f061cc with merge base 6f654eb (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69955361

swolchok pushed a commit that referenced this pull request Feb 21, 2025
Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927.

Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/)

ghstack-source-id: 267533770
Pull Request resolved: #8607
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess landing this without shipit will break Android build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants