Arm backend: Add additional tosa_supported_op checks for BI #8593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a TosaSpecification without floating point support is used, additional checks will be made during paritioning to make sure that we don't partition operators that: - are not quantized properly, i.e. does not have a dq-q pair surrounding them. - should have been decomposed prior to qunatization, e.g. div should be decomposed to a mul and recip before quantization. Change-Id: Ie6f6fca1547192087c8f54025371344fbf470278 Co-authored-by: Erik Lundell <[email protected]> Signed-off-by: Oscar Andersson <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8593
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit 44b0ba8 with merge base 75d4abc ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
zingo
approved these changes
Feb 20, 2025
|
Fails are unrelated |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 21, 2025
Summary: pytorch#8593 (D69921367) adds new imports to tosa_supported_operators.py. Add the necessary buck deps for it. Differential Revision: D70003345
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 21, 2025
Summary: pytorch#8593 (D69921367) adds new imports to tosa_supported_operators.py. Add the necessary buck deps for it. Reviewed By: JacobSzwejbka, kirklandsign Differential Revision: D70003345
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 22, 2025
Differential Revision: D70003345 Pull Request resolved: #8625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a TosaSpecification without floating point support is used, additional checks will be made during paritioning to make sure that we don't partition operators that:
cc @digantdesai @freddan80 @per @zingo