fix newline windows issue in generate_csv #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Same problem discussed here with this as a solution: https://stackoverflow.com/questions/3348460/csv-file-written-with-python-has-blank-lines-between-each-row |
ejguan
approved these changes
Jul 25, 2022
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Aug 5, 2022
Summary: Fixes pytorch#674 ### Changes updated tutorial in documentation to specify the newline explitly `writer = csv.DictWriter(open(f"sample_data{file_label}.csv", "w", newline=''), fieldnames=fieldnames)` instead of: `writer = csv.DictWriter(open(f"sample_data{file_label}.csv", "w"), fieldnames=fieldnames)` ## Testing - tested by running the generate_csv function before and after on a windows machine, before was creating newlines between lines and throwing errors, after the created files don't have newlines and full tutorial works Pull Request resolved: pytorch#675 Reviewed By: ejguan Differential Revision: D38116301 Pulled By: NivekT fbshipit-source-id: 1885c40cdc739ca70c5236e983389d88f662b2d4
ejguan
pushed a commit
that referenced
this pull request
Aug 5, 2022
Summary: Fixes #674 ### Changes updated tutorial in documentation to specify the newline explitly `writer = csv.DictWriter(open(f"sample_data{file_label}.csv", "w", newline=''), fieldnames=fieldnames)` instead of: `writer = csv.DictWriter(open(f"sample_data{file_label}.csv", "w"), fieldnames=fieldnames)` ## Testing - tested by running the generate_csv function before and after on a windows machine, before was creating newlines between lines and throwing errors, after the created files don't have newlines and full tutorial works Pull Request resolved: #675 Reviewed By: ejguan Differential Revision: D38116301 Pulled By: NivekT fbshipit-source-id: 1885c40cdc739ca70c5236e983389d88f662b2d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #674
Changes
updated tutorial in documentation to specify the newline explitly
writer = csv.DictWriter(open(f"sample_data{file_label}.csv", "w", newline=''), fieldnames=fieldnames)instead of:
writer = csv.DictWriter(open(f"sample_data{file_label}.csv", "w"), fieldnames=fieldnames)Testing