Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataPipe] Add handler argument to iopath DataPipes #1154

Closed
wants to merge 1 commit into from
Closed

[DataPipe] Add handler argument to iopath DataPipes #1154

wants to merge 1 commit into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented May 8, 2023 •
edited
Loading

Stack from ghstack:

A lot of use cases currently looks like:

dp = IoPathFileOpener(dp, mode="rb")
dp.register_handler(handler)

This allows users to register_handler within __init__:

dp = IoPathFileOpener(dp, mode="rb", handler=handler)

Differential Revision: D45667135

NivekT added a commit that referenced this pull request May 8, 2023
@NivekT
[DataPipe] Add argument to iopath DataPipes
9fae8be 
ghstack-source-id: bfe71c7c0ef378d02a3db137327130fd187064ea
Pull Request resolved: #1154
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2023
@NivekT NivekT changed the title [DataPipe] Add argument to iopath DataPipes [DataPipe] Add handler argument to iopath DataPipes May 8, 2023
@NivekT NivekT requested a review from ejguan May 8, 2023 19:02
@NivekT NivekT added the topic: improvements topic category label May 8, 2023
ejguan
ejguan approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NivekT
Copy link
Contributor Author

NivekT commented May 8, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@NivekT merged this pull request in fec1e58.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/124/head branch May 13, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejguan ejguan ejguan approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NivekT @facebook-github-bot @ejguan