-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Add round robin sharding documentation #1050
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Feb 25, 2023
ghstack-source-id: 6f3953c83898f52ce74df164a5386f41abb6b14a Pull Request resolved: #1050
ejguan
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome. Thank you so much. Let's cherrypick it before the final branch cut.
Also fixed some wording and typos [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Feb 27, 2023
ghstack-source-id: e7e39100a7cfda69c546929e7fe31dcde92273ed Pull Request resolved: #1050
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
added a commit
that referenced
this pull request
Feb 28, 2023
Summary: Pull Request resolved: #1050 Also fixed some wording and typos Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D43625322 Pulled By: NivekT fbshipit-source-id: 37adee2d72fdf20c12560eb2134ef93749ac0293
ejguan
pushed a commit
that referenced
this pull request
Feb 28, 2023
Summary: Pull Request resolved: #1050 Also fixed some wording and typos Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D43625322 Pulled By: NivekT fbshipit-source-id: 37adee2d72fdf20c12560eb2134ef93749ac0293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
documentation
Improvements or additions to documentation
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Also fixed some wording and typos
Differential Revision: D43625322