Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conda python 3.11 builds #1010

Closed
wants to merge 6 commits into from
Closed

Add conda python 3.11 builds #1010

wants to merge 6 commits into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Feb 13, 2023 •
edited
Loading

Adding conda 3.11 builds

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2023
ejguan
ejguan reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems conda couldn't find right pytorch https://github.com/pytorch/data/actions/runs/4167666057/jobs/7213693569#step:8:431

@facebook-github-bot
Copy link
Contributor

@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

malfet
malfet approved these changes Feb 14, 2023
View reviewed changes
Copy link

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed missing portalocker deps to https://anaconda.org/malfet/portalocker and re-run builds, which seem to be working now

@facebook-github-bot
Copy link
Contributor

@atalman merged this pull request in b43c07d.

@ejguan
Copy link
Contributor

ejguan commented Feb 15, 2023

Conda release on python 3.11 doesn't work due to package version conflicts:
I am going to remove fsspec from conda to seee if the issue can be resolved.

@ejguan
Copy link
Contributor

ejguan commented Feb 15, 2023

@atalman
After removing fsspec from TorchData conda meta.yml file, the conda release is still not working on windows/macos.
See https://github.com/pytorch/data/actions/runs/4187926584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejguan ejguan ejguan left review comments

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atalman @facebook-github-bot @ejguan @malfet