Skip to content

Commit

Permalink
Drop python 3.7 support as aligned with PyTorch (#974)
Browse files Browse the repository at this point in the history
Summary:
First step for #971

per title

Pull Request resolved: #974

Reviewed By: NivekT

Differential Revision: D42810503

Pulled By: ejguan

fbshipit-source-id: 128d8faacf115c0aa2ad8345cd7d348de5739dfe
  • Loading branch information
ejguan authored and facebook-github-bot committed Jan 27, 2023
1 parent 8f05ff5 commit 5960bd3
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 22 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/_build_test_upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,9 @@ jobs:
- windows-latest
- macos-m1-12
python-version:
- 3.7
- 3.8
- 3.9
- "3.10"
# Python 3.7 is not officially provided on Apple Silicon
exclude:
- os: macos-m1-12
python-version: 3.7
steps:
- name: Checkout Source Repository
uses: actions/checkout@v3
Expand Down Expand Up @@ -281,14 +276,9 @@ jobs:
- windows-latest
- macos-m1-12
python-version:
- 3.7
- 3.8
- 3.9
- "3.10"
# Python 3.7 is not officially provided on Apple Silicon
exclude:
- os: macos-m1-12
python-version: 3.7
steps:
- name: Checkout Source Repository
uses: actions/checkout@v3
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/aistore_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
- macos-latest
- ubuntu-latest
python-version:
- 3.7
- 3.8
- 3.9
steps:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
- ubuntu-latest
- windows-latest
python-version:
- 3.7
- 3.8
- 3.9
- "3.10"
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/domain_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
- ubuntu-latest
- windows-latest
python-version:
- 3.7
- 3.8
- 3.9
steps:
Expand Down Expand Up @@ -71,7 +70,6 @@ jobs:
- ubuntu-latest
- windows-latest
python-version:
- 3.7
- 3.8
- 3.9
steps:
Expand Down Expand Up @@ -116,8 +114,6 @@ jobs:
- ubuntu-latest
# - windows-latest
python-version:
# - 3.7
# - 3.8
- 3.9
steps:
- name: Setup Python ${{ matrix.python-version }}
Expand Down Expand Up @@ -161,7 +157,6 @@ jobs:
- ubuntu-latest
# - windows-latest
python-version:
- 3.7
- 3.8
- 3.9
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: "3.7"
python-version: "3.8"
- name: Check out source repository
uses: actions/checkout@v3
- name: Install lint utilities
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ The following is the corresponding `torchdata` versions and supported Python ver

| `torch` | `torchdata` | `python` |
| -------------------- | ------------------ | ----------------- |
| `master` / `nightly` | `main` / `nightly` | `>=3.7`, `<=3.10` |
| `master` / `nightly` | `main` / `nightly` | `>=3.8`, `<=3.10` |
| `1.13.1` | `0.5.1` | `>=3.7`, `<=3.10` |
| `1.12.1` | `0.4.1` | `>=3.7`, `<=3.10` |
| `1.12.0` | `0.4.0` | `>=3.7`, `<=3.10` |
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,14 +166,13 @@ def remove_extension(pattern):
author_email="[email protected]",
license="BSD",
install_requires=requirements,
python_requires=">=3.7",
python_requires=">=3.8",
classifiers=[
"Intended Audience :: Developers",
"Intended Audience :: Science/Research",
"License :: OSI Approved :: BSD License",
"Operating System :: MacOS :: MacOS X",
"Operating System :: Microsoft :: Windows",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Expand Down
2 changes: 1 addition & 1 deletion third_party/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ They are contrasted with Core dependencies that are must be installed along with
### Static Linking vs Dynamic Linking

For the third-party libraries in C, if their runtime libraries are available on both PyPI and Conda across platfroms
(Linux, MacOS, Windows and Python 3.7-3.10), it's recommended to use dynamic linking against the `torchdata`
(Linux, MacOS, Windows and Python 3.8-3.10), it's recommended to use dynamic linking against the `torchdata`
C-extension.

For the third-party libraries that are not available on PyPI and Conda, please add it as a submodule under `third_party`
Expand Down

0 comments on commit 5960bd3

Please sign in to comment.