Add a helper for evaluating feasibility of candidate points (#2565) #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitcakmak
force-pushed
the
export-D63909338
branch
from
a546b5e to
e2706b9
Compare
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63909338 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2733 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 203 203
Lines 18673 18689 +16
=======================================
+ Hits 18672 18688 +16
Misses 1 1 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Feb 6, 2025
…2733) Summary: Adds a helper for evaluating the feasibility of parameter constraints on a `batch x q x d` tensor of candidates. A follow-up diff will utilize this to detect infeasible candidates produced during optimization and raise an error rather than returning infeasible points to the user. Reviewed By: esantorella Differential Revision: D63909338
saitcakmak
force-pushed
the
export-D63909338
branch
from
e2706b9 to
e672d04
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63909338 |
…2733) Summary: Adds a helper for evaluating the feasibility of parameter constraints on a `batch x q x d` tensor of candidates. A follow-up diff will utilize this to detect infeasible candidates produced during optimization and raise an error rather than returning infeasible points to the user. Reviewed By: esantorella Differential Revision: D63909338
saitcakmak
force-pushed
the
export-D63909338
branch
from
e672d04 to
81a7ce5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63909338 |
|
This pull request has been merged in f413275. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a helper for evaluating the feasibility of parameter constraints on a
batch x q x dtensor of candidates.A follow-up diff will utilize this to detect infeasible candidates produced during optimization and raise an error rather than returning infeasible points to the user.
Differential Revision: D63909338