Update initialize_q_batch methods to return both candidates and the corresponding acquisition values
#2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64333367 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2571 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 195 195
Lines 17116 17122 +6
=======================================
+ Hits 17113 17119 +6
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 14, 2024
… corresponding acquisition values (pytorch#2571) Summary: As titled. This avoids the need to re-compute the acquisition values after sub-selecting in cases where they are needed. Differential Revision: D64333367 Pulled By: saitcakmak
saitcakmak
force-pushed
the
export-D64333367
branch
from
fee6109 to
c292356
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64333367 |
… corresponding acquisition values (pytorch#2571) Summary: As titled. This avoids the need to re-compute the acquisition values after sub-selecting in cases where they are needed. Differential Revision: D64333367 Pulled By: saitcakmak
saitcakmak
force-pushed
the
export-D64333367
branch
from
c292356 to
f2cbf99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64333367 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 14, 2024
… corresponding acquisition values (pytorch#2571) Summary: As titled. This avoids the need to re-compute the acquisition values after sub-selecting in cases where they are needed. Pull Request resolved: pytorch#2571 Differential Revision: D64333367
|
@saitcakmak merged this pull request in b79dfb0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. This avoids the need to re-compute the acquisition values after sub-selecting in cases where they are needed.
Differential Revision: D64333367