Update HigherOrderGP to use new priors #2555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63478493 |
|
This pull request was exported from Phabricator. Differential Revision: D63478493 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: pytorch#2555 As titled. This was leading to some test failures when I first tried it. Turns out it was just the reference point being a bit too aggressive and filtering out all of X_baseline. Differential Revision: D63478493
saitcakmak
force-pushed
the
export-D63478493
branch
from
e565561 to
9af3f25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2555 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 17062 17066 +4
=======================================
+ Hits 17059 17063 +4
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D63478493 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Sep 27, 2024
…rch#2555) Summary: Pull Request resolved: pytorch#2555 As titled. This was leading to some test failures when I first tried it. Turns out it was just the reference point being a bit too aggressive and filtering out all of X_baseline. Differential Revision: D63478493
saitcakmak
force-pushed
the
export-D63478493
branch
from
9af3f25 to
b5112ac
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Sep 27, 2024
…rch#2555) Summary: Pull Request resolved: pytorch#2555 As titled. This was leading to some test failures when I first tried it. Turns out it was just the reference point being a bit too aggressive and filtering out all of X_baseline. Differential Revision: D63478493
saitcakmak
force-pushed
the
export-D63478493
branch
from
b5112ac to
89e153f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63478493 |
…rch#2555) Summary: Pull Request resolved: pytorch#2555 As titled. This was leading to some test failures when I first tried it. Turns out it was just the reference point being a bit too aggressive and filtering out all of X_baseline. Differential Revision: D63478493
|
This pull request was exported from Phabricator. Differential Revision: D63478493 |
saitcakmak
force-pushed
the
export-D63478493
branch
from
89e153f to
efee323
Compare
|
This pull request has been merged in 98c1504. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. This was leading to some test failures when I first tried it but it seems to work fine now.
Differential Revision: D63478493