Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditionally skip unsupported subTest tests for Python 2 #386

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Dec 31, 2019

Makes the Travis build green.

@kostmo kostmo force-pushed the fix-py2-travis branch 2 times, most recently from 878d0b2 to ba941bd Compare December 31, 2019 01:09
@kostmo kostmo changed the title [WIP] conditionally skip unsupported subTest tests for Python 2 conditionally skip unsupported subTest tests for Python 2 Dec 31, 2019
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been nice to run the tests on python 2, but I agree this is a good enough solution for now instead of just having them failing.

@vincentqb vincentqb merged commit cdf5c83 into pytorch:master Jan 2, 2020
vincentqb added a commit to vincentqb/audio that referenced this pull request Jan 22, 2020
vincentqb added a commit that referenced this pull request Jan 22, 2020
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
Normalized loss in actor-critic and REINFORCE examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants