Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.7.1] Update documentation #1067

Merged
merged 1 commit into from
Dec 7, 2020
Merged

[0.7.1] Update documentation #1067

merged 1 commit into from
Dec 7, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Dec 4, 2020

  • Bump version to 0.7.1
  • Checkout changes from the latest

@mthrok
Update documentation
2888dd6 
* bump version to 0.7.1
* Checkout changes from the latest
vincentqb
vincentqb approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vincentqb
vincentqb reviewed Dec 4, 2020
View reviewed changes
docs/source/functional.rst
@@ -8,145 +8,176 @@ torchaudio.functional

Functions to perform common audio operations.

:hidden:`spectrogram`
~~~~~~~~~~~~~~~~~~~~~
:hidden:`Filtering`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the functionals aren't moved in 0.7 but this subsection isn't visible, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is visible. hidden here is a command to tell doxygen which class it should use to render this section.
Filtering subsection is for the improved user experience and has nothing to do with where the location these functions are defined.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this seems reasonable

@mthrok mthrok merged commit 7ff61fd into pytorch:release/0.7 Dec 7, 2020
@mthrok mthrok deleted the release/0.7 branch December 7, 2020 15:46
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
@subramen
Add code for DDP tutorial series [PR 1 / 3] (pytorch#1067)
f45e418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mthrok @vincentqb @facebook-github-bot