Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip test_int8_dynamic_quant_subclass_api in test_integration.py #1375

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

sanchitintel
Copy link
Contributor

@sanchitintel sanchitintel commented Dec 4, 2024

test_int8_dynamic_quant_subclass_api in test/integration/test_integration.py is being skipped for PyTorch versions equal to or above 2.4 but it now passes for both CPU & CUDA.

Copy link

pytorch-bot bot commented Dec 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1375

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 481cf11 with merge base b7630f1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2024
@sanchitintel sanchitintel marked this pull request as ready for review December 4, 2024 00:43
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Dec 4, 2024
@msaroufim msaroufim self-requested a review December 4, 2024 16:29
@msaroufim msaroufim merged commit 04d611a into pytorch:main Dec 4, 2024
17 of 19 checks passed
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
If the chat is exited or interrupted it will still print the stats with
NaN values which is unnecessary.

Signed-off-by: Sébastien Han <[email protected]>
amdfaa pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants