Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update torchao api reference and add contributor guide #1255

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Nov 8, 2024

Summary:

  1. updated torchao api reference for quantization to include the APIs we want to expose, renamed torchao/quantization/linear_activation_weight_observer.py and removed the safe_int_mm and int_scaled_matmul from quant_primitives.py
  2. added [RFC] torchao Contributor Guide #391 to torchao docs

For torchao docs, I think we can include:
(1) API Reference (for modeling users)
(2) contributor guide (for researchers/developers)
(3) Tutorials (for modeling users)

for major feature announcement etc. users should refer to torchao repo README and release notes

Test Plan:
CI

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Nov 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1255

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f10990a with merge base f96e5ec (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 8, 2024
@jerryzh168 jerryzh168 added the topic: documentation Use this tag if this PR adds or improves documentation label Nov 8, 2024
docs/source/index.rst Outdated Show resolved Hide resolved
Summary:
1. updated torchao api reference for quantization to include the APIs we want to expose, renamed torchao/quantization/linear_activation_weight_observer.py
and removed the safe_int_mm and int_scaled_matmul from quant_primitives.py
2. added pytorch#391 to torchao docs

Test Plan:
CI

Reviewers:

Subscribers:

Tasks:

Tags:
docs/source/contributor_guide.rst Outdated Show resolved Hide resolved
docs/source/contributor_guide.rst Show resolved Hide resolved
docs/source/contributor_guide.rst Outdated Show resolved Hide resolved
@jerryzh168 jerryzh168 merged commit 39f16f4 into pytorch:main Nov 13, 2024
18 checks passed
sunjiweiswift pushed a commit to sunjiweiswift/ao that referenced this pull request Nov 25, 2024
* Update torchao api reference and add contributor guide

Summary:
1. updated torchao api reference for quantization to include the APIs we want to expose, renamed torchao/quantization/linear_activation_weight_observer.py
and removed the safe_int_mm and int_scaled_matmul from quant_primitives.py
2. added pytorch#391 to torchao docs

Test Plan:
CI

Reviewers:

Subscribers:

Tasks:

Tags:

* format

* typo

* renaming

* comma

* format

* comments
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* feat(granite): Add support for finding weight mapping files with other names

Branch: GraniteCodeSupport

Signed-off-by: Gabe Goodhart <[email protected]>

* feat(granite): Add support for loading state_dict from safetensors

Branch: GraniteCodeSupport

Signed-off-by: Gabe Goodhart <[email protected]>

* feat(safetensors): Use model_info to determine whether to download pth or safetensors

The logic here will prefer pth over safetensors unless the model's config
explicitly states a preference for safetensors over pth. If only one of the
two is found, the download will use whichever is present.

Branch: GraniteCodeSupport

Signed-off-by: Gabe Goodhart <[email protected]>

---------

Signed-off-by: Gabe Goodhart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: documentation Use this tag if this PR adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants