-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic support for split #2871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/conversion/test_split_aten.py 2024-05-30 21:44:49.741396+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/conversion/test_split_aten.py 2024-05-30 21:46:43.525899+00:00
@@ -135,11 +135,11 @@
Input(
dtype=torch.float32,
min_shape=[1, 10, 1],
opt_shape=[1, 10, 10],
max_shape=[1, 10, 10],
- name = "input",
+ name="input",
),
]
self.run_test_with_dynamic_shape(
TestModule(),
input_specs,
@@ -163,18 +163,17 @@
Input(
dtype=torch.float32,
min_shape=[1, 10, 10],
opt_shape=[3, 10, 10],
max_shape=[5, 10, 10],
- name = "input",
+ name="input",
),
]
self.run_test_with_dynamic_shape(
TestModule(),
input_specs,
)
-
@parameterized.expand(
[
("select_chunk_dim", 6, 0),
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/conversion/test_split_aten.py 2024-05-30 21:44:48.482825+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/conversion/test_split_aten.py 2024-05-30 21:47:47.511710+00:00
@@ -135,11 +135,11 @@
Input(
dtype=torch.float32,
min_shape=[1, 10, 1],
opt_shape=[1, 10, 10],
max_shape=[1, 10, 10],
- name = "input",
+ name="input",
),
]
self.run_test_with_dynamic_shape(
TestModule(),
input_specs,
@@ -163,18 +163,17 @@
Input(
dtype=torch.float32,
min_shape=[1, 10, 10],
opt_shape=[3, 10, 10],
max_shape=[5, 10, 10],
- name = "input",
+ name="input",
),
]
self.run_test_with_dynamic_shape(
TestModule(),
input_specs,
)
-
@parameterized.expand(
[
("select_chunk_dim", 6, 0),
]
@cehongwang have you set up the precommit system, it can help you with the linting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM. pending CI
Co-authored-by: cehongwang <[email protected]>
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Updated and added test cases for dynamic shape of split function
Add dynamic shape support tag in function decorator of converter
Checklist: