Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing parameters in compiler settings #2749

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

gs-olive
Copy link
Collaborator

Description

  • DLA parameters were not being propagated through the compiler specification in the TorchScript path

Fixes #2731

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive requested a review from narendasan April 12, 2024 20:52
@gs-olive gs-olive self-assigned this Apr 12, 2024
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Apr 12, 2024
@github-actions github-actions bot requested a review from peri044 April 12, 2024 20:52
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit b76024d into pytorch:main Apr 12, 2024
18 of 24 checks passed
@gs-olive gs-olive deleted the dram_parameter_propagation branch April 12, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Unable to Change DLA Local DRAM when using torch_tensorrt.compile
3 participants