Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: param bug in test_binary_ops_aten #2733

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: param bug in test_binary_ops_aten #2733

merged 1 commit into from
Apr 16, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Fixed a param bug in test_binary_ops_aten. The param is required to be a tuple instead of a single value.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 added bug Something isn't working component: converters Issues re: Specific op converters labels Apr 8, 2024
@zewenli98 zewenli98 self-assigned this Apr 8, 2024
@github-actions github-actions bot added component: tests Issues re: Tests and removed component: converters Issues re: Specific op converters labels Apr 8, 2024
gs-olive
gs-olive approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Were these tests getting skipped before?

@zewenli98
Copy link
Collaborator Author

Looks good to me! Were these tests getting skipped before?

I think so. Not sure why they were skipped in CI

@zewenli98 zewenli98 merged commit 31d83f6 into pytorch:main Apr 16, 2024
27 of 32 checks passed
peri044 pushed a commit that referenced this pull request Apr 19, 2024
@zewenli98 @peri044
fix: param bug in test_binary_ops_aten (#2733)
25a3b28
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@zewenli98 @laikhtewari
fix: param bug in test_binary_ops_aten (#2733)
0346a29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gs-olive gs-olive gs-olive approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@peri044 peri044 Awaiting requested review from peri044

@apbose apbose Awaiting requested review from apbose

Assignees

@zewenli98 zewenli98

Labels
bug Something isn't working cla signed component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zewenli98 @gs-olive @facebook-github-bot