-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support 1d ITensor offsets for embedding_bag converter #2677
feat: support 1d ITensor offsets for embedding_bag converter #2677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a great improvement to embedding_bag
; added a few small comments and suggestions
Thanks for the review! I just refactored the embedding_bag with native TRT layers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good! Added one small comment, and pending CI validation
This is currently blocked by a Myelin bug. Filed a NVBug internally. |
… native TRT layers
2d40091
to
1f58d47
Compare
With the latest |
Description
Support 1d ITensor offsets for embedding_bag converter.
Note that this is only for 1d inputs.
There's a bug that same offsets with different types (tensor or ITensor) when include_last_offset=True will give different results. I doubt this is a bug from PyTorch, I'm still investigating it.
Fixes #2345
Type of change
Checklist: