chore: Update layer_norm converter to use INormalizationLayer #2509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the aten::layer_norm converter to use INormalizationLayer. Resolves warning about precision:
WARNING: [Torch-TensorRT TorchScript Conversion Context] - Running layernorm after self-attention in FP16 may cause overflow. Exporting the model to the latest available ONNX opset (later than opset 17) to use the INormalizationLayer, or forcing layernorm layers to run in FP32 precision can help with preserving accuracy.
More closely matches behavior of onnx-tensorrt https://github.com/onnx/onnx-tensorrt/blob/main/builtin_op_importers.cpp#L2270
Covered by existing aten::layer_norm converter tests (updated to remove reshape which invalidates test).
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: