Improve the first overload of is_dataclass
#9758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
commented
Feb 19, 2023
Comment on lines
+63
to
+70
| # Mypy correctly emits an error on these due to the fact | ||
| # that it's a dataclass class, not a dataclass instance. | ||
| # Pyright, however, handles ClassVar members in protocols differently. | ||
| # See https://github.com/microsoft/pyright/issues/4339 | ||
| # | ||
| # dc.asdict(x) | ||
| # dc.astuple(x) | ||
| # dc.replace(x) |
There was a problem hiding this comment.
We could possibly put these tests inside an if MYPY block, and add "defineConstant": { "MYPY": false } } to our pyrightconfig file for our test cases, to ensure that pyright doesn't check any code inside if MYPY blocks. I'm sort-of wary of doing that, however, as I'd really like to keep typechecker-specific test cases to a minimum in typeshed.
JelleZijlstra
approved these changes
Feb 19, 2023
JelleZijlstra
approved these changes
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9723. I think this is the best compromise for now.