-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyautogui
: just skip stubtest
#8678
Conversation
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into whether we could fudge this with environment variables, but it really does need an actual display it can talk to at import time.
(Also, remind me not to try to install pyautogui on a Mac, it installs like 100 dependencies.)
We could use |
Interesting. Would this slow down running stubtest at all? Would there be a way of specifying in |
It would slow starting stubtest, but only by about 300ms:
Once stubtest is running, it has a |
Sounds great to me, in that case! |
Could we maybe unskip stubtesting typeshed/stubs/pynput/METADATA.toml Line 4 in 8e4b89a
|
@Akuli, could you work up a PR for this? (GitHub Actions are... not my strong suit.) |
Sure. I'll probably get it done during this weekend :) |
I realised immediately after merging the pyautogui PR that there's not much point running stubtest on this package, since stubtest isn't able to import any of PyAutoGUI without access to a display screen