fix(redis): commands from asyncio module must be async #7820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis-py has introduced an asyncio module since 4.2 and almost all commands should be async if the redis.asyncio.Redis is used instead of redis.Redis. This changes adds the types for all core commands. Related to python#7597
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Thx @AlexWaygood for the CI fix. |
sileht
added a commit
to sileht/mergify-community
that referenced
this pull request
May 10, 2022
We have to vendor redis-py typing because types-redis has an incomplete redis.asyncio module typing. I proposed my typing here: python/typeshed#7820 The change also makes mypy discovers some un-catched typing issue.
sileht
added a commit
to sileht/mergify-community
that referenced
this pull request
May 10, 2022
We have to vendor redis-py typing because types-redis has an incomplete redis.asyncio module typing. I proposed my typing here: python/typeshed#7820 The change also makes mypy discovers some un-catched typing issue.
sileht
added a commit
to sileht/mergify-community
that referenced
this pull request
May 10, 2022
We have to vendor redis-py typing because types-redis has an incomplete redis.asyncio module typing. I proposed my typing here: python/typeshed#7820 The change also makes mypy discovers some un-catched typing issue.
sileht
added a commit
to sileht/mergify-community
that referenced
this pull request
May 10, 2022
We have to vendor redis-py typing because types-redis has an incomplete redis.asyncio module typing. I proposed my typing here: python/typeshed#7820 The change also makes mypy discovers some un-catched typing issue.
sileht
added a commit
to sileht/mergify-community
that referenced
this pull request
May 11, 2022
We have to vendor redis-py typing because types-redis has an incomplete redis.asyncio module typing. I proposed my typing here: python/typeshed#7820 The change also makes mypy discovers some un-catched typing issue.
sileht
added a commit
to sileht/mergify-community
that referenced
this pull request
May 23, 2022
We have to vendor redis-py typing because types-redis has an incomplete redis.asyncio module typing. I proposed my typing here: python/typeshed#7820 The change also makes mypy discovers some un-catched typing issue.
sileht
added a commit
to sileht/mergify-community
that referenced
this pull request
May 23, 2022
We have to vendor redis-py typing because types-redis has an incomplete redis.asyncio module typing. I proposed my typing here: python/typeshed#7820 The change also makes mypy discovers some un-catched typing issue.
sileht
added a commit
to sileht/mergify-community
that referenced
this pull request
May 30, 2022
We have to vendor redis-py typing because types-redis has an incomplete redis.asyncio module typing. I proposed my typing here: python/typeshed#7820 The change also makes mypy discovers some un-catched typing issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis-py has introduced an asyncio module since 4.2 and almost all
commands should be async if the redis.asyncio.Redis is used instead of
redis.Redis.
This changes adds the types for all core commands.
Related to #7597