Add missing redis modules and classes #7676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most types were taken from the partly-annotated upstream code base. I didn't double check them, just cleaned them up. |
|
I tried to track down the pytype errors, but without success. Cc @rchen152 |
I'll look into it today. |
|
I've got a fix for the pytype issue out for review. Hopefully I'll be able to do a release tomorrow. |
rchen152
added a commit
to google/pytype
that referenced
this pull request
Apr 26, 2022
Fixes pytype test failures seen in python/typeshed#7676 by doing more extensive re-resolving of external types upon encountering circular imports. This also lets us remove a previous hack that we put in to partially work around this problem. PiperOrigin-RevId: 444427690
rchen152
added a commit
to google/pytype
that referenced
this pull request
Apr 26, 2022
Fixes pytype test failures seen in python/typeshed#7676 by doing more extensive re-resolving of external types upon encountering circular imports. This also lets us remove a previous hack that we put in to partially work around this problem. PiperOrigin-RevId: 444427690
|
Just pushed out pytype-2022.4.26, which should fix this issue. |
JelleZijlstra
added a commit
to JelleZijlstra/redis-py
that referenced
this pull request
Apr 30, 2022
NoReturn should be used only when the function never returns. In this case, the awaitable returns None if releasing the lock succeeds, so `Awaitable[None]` is right. Noticed this while reviewing python/typeshed#7676
6 tasks
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Apr 30, 2022
AlexWaygood
reviewed
Apr 30, 2022
chayim
pushed a commit
to redis/redis-py
that referenced
this pull request
May 2, 2022
NoReturn should be used only when the function never returns. In this case, the awaitable returns None if releasing the lock succeeds, so `Awaitable[None]` is right. Noticed this while reviewing python/typeshed#7676
|
@srittau, from redis.asyncio import RedisCluster as AsyncRedisCluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds asyncio support
Closes #7597