Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix float.__rpow__ #7047

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix float.__rpow__ #7047

merged 1 commit into from
Jan 27, 2022

Conversation

JelleZijlstra
Copy link
Member

Fixes #7046.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit d5101dc into master Jan 27, 2022
@hauntsaninja hauntsaninja deleted the JelleZijlstra-patch-1 branch January 27, 2022 03:18
@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jan 27, 2022 •
edited
Loading

Thanks! floats aren't valid literals, so guess we can't do a _PositiveInteger style hack for 2.0 ** 1.0 style things

@JelleZijlstra
Copy link
Member Author

We could do an overload for literal ints if we want though.

@AlexWaygood AlexWaygood mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mypy infers wrong type for -2 ** 0.5
2 participants
@JelleZijlstra @hauntsaninja