Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SupportsIndex support for math and cmath #6216

Merged
merged 6 commits into from
Oct 31, 2021
Merged

Update SupportsIndex support for math and cmath #6216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9d7c0c
SupportsIndex for cmath
A5rocks Oct 31, 2021
99af850
Don't support __index__ on <3.7
A5rocks Oct 31, 2021
1c5c37b
Formatting (oops)
A5rocks Oct 31, 2021
bb044d6
math.factorial only accepts int <3.8
A5rocks Oct 31, 2021
463b9f7
Please black
A5rocks Oct 31, 2021
da8c3f3
Actually compare against the right version
A5rocks Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion stdlib/cmath.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import sys
from typing import SupportsComplex, SupportsFloat, Union

if sys.version_info >= (3, 8):
from typing import SupportsIndex

e: float
pi: float
inf: float
Expand All @@ -8,7 +12,10 @@ nan: float
nanj: complex
tau: float

_C = Union[SupportsFloat, SupportsComplex, complex]
if sys.version_info >= (3, 8):
_C = Union[SupportsFloat, SupportsComplex, SupportsIndex, complex]
else:
_C = Union[SupportsFloat, SupportsComplex, complex]

def acos(__z: _C) -> complex: ...
def acosh(__z: _C) -> complex: ...
Expand Down
13 changes: 11 additions & 2 deletions stdlib/math.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ from _typeshed import SupportsTrunc
from typing import Iterable, SupportsFloat, Union, overload
from typing_extensions import SupportsIndex

_SupportsFloatOrIndex = Union[SupportsFloat, SupportsIndex]
if sys.version_info >= (3, 8):
_SupportsFloatOrIndex = Union[SupportsFloat, SupportsIndex]
else:
_SupportsFloatOrIndex = SupportsFloat

e: float
pi: float
Expand Down Expand Up @@ -36,7 +39,13 @@ def erfc(__x: _SupportsFloatOrIndex) -> float: ...
def exp(__x: _SupportsFloatOrIndex) -> float: ...
def expm1(__x: _SupportsFloatOrIndex) -> float: ...
def fabs(__x: _SupportsFloatOrIndex) -> float: ...
def factorial(__x: SupportsIndex) -> int: ...

if sys.version_info >= (3, 8):
def factorial(__x: SupportsIndex) -> int: ...

else:
def factorial(__x: int) -> int: ...

def floor(__x: _SupportsFloatOrIndex) -> int: ...
def fmod(__x: _SupportsFloatOrIndex, __y: _SupportsFloatOrIndex) -> float: ...
def frexp(__x: _SupportsFloatOrIndex) -> tuple[float, int]: ...
Expand Down