Don't use basestring in tempfile stub #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JukkaL Thanks! |
momandine
pushed a commit
to momandine/typeshed
that referenced
this pull request
Jul 5, 2016
(This is a little sad when using py.test, but it's the idiom used in the stdlib, and it allows testing with -O.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202.
TemporaryDirectoryhas someAnytypes because we have no way of inferring a precise return or attribute type in all cases. I chose to useAnyinstead of a union type since the latter would require a cast orisinstance()on many call sites.Mypy has trouble with some of the definitions such as
mkdtemp(python/mypy#1541) but this is acceptable since it falls back toAnyinstead of inferring an incorrect type.