Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redis] Don't recommend uninstalling types-redis #10694

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Sep 11, 2023

Cf. #10592

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add something in the extra_description field noting that upstream does have a py.typed, but that these stubs might be useful anyway?

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Stubsabot will file a PR trying to mark these stubs as obsolete again, but we can mark it as "DO-NOT-MERGE".

We may possibly want to add some kind of stubsabot_ignore field to METADATA.toml files, for stubs packages where we just want stubsabot to go away for now. Right now we've got redis and tree-sitter; previously we had pyvmomi (see discussion in #10149)

@srittau srittau merged commit c31e12f into python:main Sep 12, 2023
@srittau srittau deleted the redis-removal branch September 12, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants