-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distutils
package was removed in 3.12
#10249
Conversation
What should we do with
? |
This comment has been minimized.
This comment has been minimized.
I think that |
Maybe we could import those things from |
Looks like |
|
This comment has been minimized.
This comment has been minimized.
Diff from mypy_primer, showing the effect of this PR on open source code: apprise (https://github.com/caronc/apprise)
- setup.py:74: error: Argument "cmdclass" to "setup" has incompatible type "Dict[str, Type[babel.messages.frontend.Command]]"; expected "Mapping[str, Type[setuptools._distutils.cmd.Command]]" [arg-type]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'd appreciate a third opinion from somebody
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems approximately fine to me and unlikely to cause regressions. We can later investigate what exactly these packages do whenever they claim 3.12 support.
Source: python/cpython@0faa0ba