Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily tests failed on Thu Feb 23 2023 #9799

Closed
github-actions bot opened this issue Feb 23, 2023 · 1 comment · Fixed by #9800
Closed

Daily tests failed on Thu Feb 23 2023 #9799

github-actions bot opened this issue Feb 23, 2023 · 1 comment · Fixed by #9800
Labels
help wanted An actionable problem of low to medium complexity where a PR would be very welcome

Comments

@github-actions
Copy link
Contributor

Runs listed here: https://github.com/python/typeshed/actions/workflows/daily.yml
@github-actions github-actions bot added the help wanted An actionable problem of low to medium complexity where a PR would be very welcome label Feb 23, 2023
@AlexWaygood
Copy link
Member

AlexWaygood commented Feb 23, 2023 •
edited
Loading

setuptools:

error: setuptools._distutils.core.Distribution.announce is inconsistent, runtime argument "level" has a default value of 20, which is different from stub argument default 2
Stub: at line 106 in file /home/runner/work/typeshed/typeshed/stubs/setuptools/setuptools/_distutils/core.pyi
def (self: distutils.dist.Distribution, msg: Any, level: Any =)
Runtime: at line 960 in file /tmp/tmpdwtx47d7/lib/python3.10/site-packages/setuptools/_distutils/dist.py
def (self, msg, level=20)

#9795 would fix it.

Or we could remove the default value here, and that would also fix it:

typeshed/stdlib/distutils/dist.pyi

Line 106 in 06755e1

def announce(self, msg, level=2) -> None: ...

Or we could change this line, so that we no longer pretend that setuptools's Distribution class is the same as the stdlib's Distribution class:

typeshed/stubs/setuptools/setuptools/_distutils/core.pyi

Line 3 in 06755e1

from distutils.dist import Distribution as Distribution

AlexWaygood added a commit that referenced this issue Feb 23, 2023
@AlexWaygood
Remove a default value in distutils
897ede1 
Fixes #9799.

Stubtest started failing on our `setuptools` stubs because of a default value added to our stdlib `distutils` stubs. The reason for this is because our `setuptools` stubs erroneously claim here that the `setuptools._distutils.core.Distribution` class is the same as the stdlib `distutils.dist.Distribution` class:

https://github.com/python/typeshed/blob/06755e10ba0d39e7e4c18fcc2663d9da564a71ad/stubs/setuptools/setuptools/_distutils/core.pyi#L3

In actual fact, they're not, and they have different default values for this parameter. But reverting the addition of the default value is the simplest short-term fix for now.

(An alternative fix would be to just merge #9795.)
@AlexWaygood AlexWaygood mentioned this issue Feb 23, 2023
Merged
AlexWaygood added a commit that referenced this issue Feb 23, 2023
@AlexWaygood
Remove a default value in distutils (#9800)
f6df5b5 
Fixes #9799.

Stubtest started failing on our `setuptools` stubs because of a default value added to our stdlib `distutils` stubs. The reason for this is because our `setuptools` stubs erroneously claim here that the `setuptools._distutils.core.Distribution` class is the same as the stdlib `distutils.dist.Distribution` class:

https://github.com/python/typeshed/blob/06755e10ba0d39e7e4c18fcc2663d9da564a71ad/stubs/setuptools/setuptools/_distutils/core.pyi#L3

In actual fact, they're not, and they have different default values for this parameter. But reverting the addition of the default value is the simplest short-term fix for now.

(An alternative fix would be to just merge #9795.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted An actionable problem of low to medium complexity where a PR would be very welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove a default value in distutils python/typeshed
1 participant
@AlexWaygood