Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy_primer commenting is still broken #5459

Closed
Akuli opened this issue May 15, 2021 · 5 comments · Fixed by #5462
Closed

mypy_primer commenting is still broken #5459

Akuli opened this issue May 15, 2021 · 5 comments · Fixed by #5462

Comments

@Akuli
Copy link
Collaborator

Akuli commented May 15, 2021

See #5458 for example. Now mypy_primer runs but it fails to post comment. Previous fix attempt was #5452.
@Akuli
Copy link
Collaborator Author

Akuli commented May 15, 2021

Can't reproduce on my fork. I have the same exact config, but the comment still appears in my test PR.

@srittau srittau mentioned this issue May 15, 2021
Merged
srittau added a commit that referenced this issue May 15, 2021
@srittau
Try to fix mypy_primer permissions (#5462)
056981b 
Cf.  #5459
@srittau
Copy link
Collaborator

srittau commented May 15, 2021

Reopening for now, not sure this is really closed.

@srittau srittau reopened this May 15, 2021
@JelleZijlstra
Copy link
Member

It's still broken with Error: Unhandled error: HttpError: Resource not accessible by integration. https://github.com/python/typeshed/pull/5473/checks?check_run_id=2595427742

srittau added a commit to srittau/typeshed that referenced this issue May 16, 2021
@srittau
Give primer comment task all write permissions
c1c018b 
Cf. python#5459
@srittau srittau mentioned this issue May 16, 2021
Merged
@srittau
Copy link
Collaborator

srittau commented May 16, 2021

If that doesn't help, the only thing left to try is to remove the permissions block and reset the repository permissions to default to "write", not "read".

JelleZijlstra pushed a commit that referenced this issue May 16, 2021
@srittau
Give primer comment task all write permissions (#5475)
d72b1e8 
Cf. #5459
@Akuli Akuli mentioned this issue May 17, 2021
Merged
@JelleZijlstra
Copy link
Member

It works again now, see #5473. Thanks to both of you for all the work getting this running again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try to fix mypy_primer permissions srittau/typeshed
3 participants
@srittau @JelleZijlstra @Akuli