Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imaplib's CommandResults has unnecessary Any #3654

Closed
dkg opened this issue Jan 24, 2020 · 1 comment
Closed

imaplib's CommandResults has unnecessary Any #3654

dkg opened this issue Jan 24, 2020 · 1 comment

Comments

@dkg
Copy link

dkg commented Jan 24, 2020

In imaplib, CommandResults is too generic.

imaplib's documentation says:

Each command returns a tuple: (type, [data, ...]) where type is usually 'OK' or 'NO' , and data is either the text from the command response, or mandated results from the command. Each data is either a string, or a tuple. If a tuple, then the first part is the header of the response, and the second part contains the data (ie: ‘literal’ value).

However, use of imaplib in python3 reveals this documentation to date from py2's confusion between bytes and strings, because the "strings" are actually bytes.

@hauntsaninja
Copy link
Collaborator

Closing based on discussion in #3655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants