Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

click.option prompt parameter can be Union[Text, bool] #1693

Closed
fizyk opened this issue Oct 27, 2017 · 0 comments · Fixed by #1699
Closed

click.option prompt parameter can be Union[Text, bool] #1693

fizyk opened this issue Oct 27, 2017 · 0 comments · Fixed by #1699

Comments

@fizyk
Copy link
Contributor

fizyk commented Oct 27, 2017

https://github.com/python/typeshed/blob/master/third_party/2and3/click/decorators.pyi#L94 defines it only as bool, however click docs themselves suggest http://click.pocoo.org/6/options/#prompting
@fizyk fizyk mentioned this issue Nov 4, 2017
Merged
JelleZijlstra pushed a commit that referenced this issue Nov 4, 2017
@fizyk @JelleZijlstra
click.*option function parameter to accepts bool and Text (#1699)
81191e4 
This follows documentation and code which allows to use both bool and Text.
Update all the prompt arguments for all *option functions in click.decorators module
since they're mostly proxying the call to option setting desired defaults.

closes #1693
@dmtucker dmtucker mentioned this issue Oct 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

click.*option function parameter to accepts bool and Text
1 participant
@fizyk