Add benchmark for deepcopy #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
requested changes
May 24, 2022
pyperformance/data-files/benchmarks/bm_deepcopy/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_deepcopy/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_deepcopy/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_deepcopy/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_deepcopy/run_benchmark.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Snow <[email protected]>
Co-authored-by: Eric Snow <[email protected]>
eendebakpt
force-pushed
the
deepcopy_benchmark
branch
from
a83c0a4 to
a777604
Compare
@ericsnowcurrently Changes made. |
|
Thanks, @eendebakpt. I'll take a look as soon as I can. |
ericsnowcurrently
requested changes
Jun 6, 2022
There was a problem hiding this comment.
Mostly LGTM. There are a few really minor things that I won't even bother mentioning. 😄 The only thing worth looking at is the overhead of everything going on the in the various loops in the one benchmark. My recommendation doesn't impact readability all that much so you might as well apply it, just in case.
pyperformance/data-files/benchmarks/bm_deepcopy/run_benchmark.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Snow <[email protected]>
|
Thanks for the benchmark, @eendebakpt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One python method that is currently not in the pyperformance benchmarks is
deepcopy. This PRs adds a benchmark that tests performance ofdeepcopyon a nested dictionary and a dataclass.The dictionary and dataclass have been chosen as example of structures can are often copied and then modified. (e.g. passing configuration settings to a method that modifies one of the settings before passing it on)
Fixes #199