Don't expand global variables in body of a function with constrained type variables #9882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith constrained type variables
JukkaL
reviewed
Jan 6, 2021
| # a trivial copy, or do something completely different? See | ||
| # testGenericFunctionAliasExpand for an example where this is important. | ||
| if original.kind != GDEF: | ||
| target = self.visit_var(target) |
There was a problem hiding this comment.
If you remove visit_mypy_file from the class (I think that it's unused), this will be completely reasonable, since this will be reference to something outside the AST node we are transforming.
There was a problem hiding this comment.
Maybe also update the docstring that this can only be used to transform functions or classes, not top-level statements and such.
JukkaL
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See first test case for the scenario where this causes issues (the second test case is already handled elsewhere and just added for completeness). This is an old issue, but it is important to fix it now because recent changes to PEP 484 about re-export force people to use function aliases.