Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py39: fix mypyc complaint #9552

Merged
merged 1 commit into from
Oct 8, 2020
Merged

py39: fix mypyc complaint #9552

merged 1 commit into from
Oct 8, 2020

Conversation

hauntsaninja
Copy link
Collaborator

I was trying to build wheels for Python 3.9 as part of #9536, but ran
into this issue. You'll notice a couple hundred lines up msullivan
points out that mypyc can't handle conditional method definition, so
that's not an option here.

/pip/_vendor/pep517/_in_process.py prepare_metadata_for_build_wheel /tmp/tmpok7vxky0
    mypy/fastparse.py:1260: error: "ExtSlice" has no attribute "dims"
    mypy/fastparse.py:1264: error: "Index" has no attribute "value"
ERROR: Command errored out with exit status 1: /opt/_internal/cpython-3.9.0rc2/bin/python3.9 /opt/_internal/cpython-3.9.0rc2/lib/python3.9/site-packages/pip/_vendor/pep517/_in_process.py prepare_metadata_for_build_wheel /tmp/tmpok7vxky0 Check the logs for full command output.

py39: fix mypyc complaint
acd6034 
I was trying to build wheels for Python 3.9 as part of python#9536, but ran
into this issue. You'll notice a couple hundred lines up msullivan
points out that mypyc can't handle conditional method definition, so
that's not an option here.
msullivan
msullivan approved these changes Oct 8, 2020
View reviewed changes
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh!

@hauntsaninja hauntsaninja merged commit ab1bd98 into python:master Oct 8, 2020
@hauntsaninja hauntsaninja deleted the wheel branch October 8, 2020 18:18
@hauntsaninja hauntsaninja mentioned this pull request Oct 13, 2020
Closed
@hauntsaninja hauntsaninja mentioned this pull request Dec 10, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauntsaninja @msullivan