Make incremental mode the default #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Mar 27, 2018
docs/source/command_line.rst
Outdated
| @@ -342,6 +342,9 @@ Here are some more useful flags: | |||
| when most parts of your program haven't changed since the previous | |||
| mypy run. | |||
|
|
|||
| Incremental mode is now the default and may be disabled with | |||
There was a problem hiding this comment.
This is not a news entry, I'd leave "now" off.
Also could you regenerate the option summary at the top of this file? There's a [-i] tucked in there somewhere that probably should go, and [--no-incremental] should appear.
emmatyping
reviewed
Mar 27, 2018
docs/source/command_line.rst
Outdated
| @@ -342,6 +342,9 @@ Here are some more useful flags: | |||
| when most parts of your program haven't changed since the previous | |||
| mypy run. | |||
|
|
|||
| Incremental mode is now the default and may be disabled with | |||
| ``--no-incremental``. | |||
|
|
|||
| - ``--cache-dir DIR`` is a companion flag to ``-incremental``, which | |||
There was a problem hiding this comment.
Since incremental mode is the default, this should probably be updated, as people usually won't be passing --incremental itself. Also above, the first --incremental after the section heading should probably be changed to Incremental mode.
msullivan
force-pushed
the
default-incremental
branch
from
dc4a7c9 to
60e37ad
Compare
|
Made the suggested doc updates and rebased, but we still want #4841 to go in first |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.