-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not import List, Dict, and Set by default #2863
Conversation
Thanks! You can add the typeshed sync to this PR yourself. |
I need to test this carefully against our internal codebases and I'm having some problems with that due to the typed-ast change. Bear with me. |
I also see this strange typed_ast error, it didn't appear before I (finally) synced typeshed. |
I fixed the |
Thanks! Now I need to focus on other stuff. |
Thank you!
Sure, no problem, take your time! |
Fix #999
This is a straightforward fix:
List
,Set
, andDict
are treated as aliases to theirbuiltins
counterparts, therefore they are ignored byremove_imported_names_from_symtable
, I fix this by also removing the alias names.This depends on python/typeshed#933 + sync typeshed
The fix also revealed few places in mypy where imports were missing.