Allow Void typed values as returns from None functions #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failing is one that explicitly tests that there is an error when attempting this :/ |
JukkaL
requested changes
Mar 6, 2017
test-data/unit/check-statements.test
Outdated
| def f() -> None: | ||
| return None | ||
| def g() -> None: | ||
| return f() # E: No return value expected |
There was a problem hiding this comment.
Can you keep the test case, but just remove the error message? I.e. it would test that this no longer generates an error message.
|
This PR looks good to me. It is still marked with |
|
This has been superseded by a more complete fix in #3024. Thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2828