Show the signature of __call__ for arguments with incompatible types …

[MechanicalConstruct]

fixes issue #17840
Check if callee_type.is_protocol if so calls find_member like before on the callee_type and then calls self.note_call() to report the note.
Checks if isinstance(Overloaded) and does nothing for now since it returns

note: "C.__call__" has type overloaded function

which in my opinion is unhelpful.
Updated test cases to reflect all of the changes.

[hauntsaninja]

Nice, thank you! One small note re: your question

[hauntsaninja]

If I'm tracing this right, for overloaded functions it will just print "overloaded function". So I'd say, yes, we should print (and whatever we do, we should probably be consistent with the other branch)

[MechanicalConstruct]

I updated it to remove the overloaded check, should now print "overloaded function" consistent with the other note.
Thanks

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/application.py:1097:38: note: "RoleFunction.__call__" has type "Callable[[str, str, str, int, Inliner, DefaultArg(dict[str, Any] | None, 'options'), DefaultArg(Sequence[str], 'content')], tuple[list[Node], list[system_message]]]"

steam.py (https://github.com/Gobot1234/steam.py)
+ steam/ext/commands/commands.py:916: note: "Check[bool | Coroutine[Any, Any, bool]].__call__" has type overloaded function

[hauntsaninja]

Thank you!

If you want a related follow-up, it could be nice to render Callable[[Arg(int, 'x'), Arg(int, 'y')], Any] as (x: int, y: int) -> Any. The argument constructors from mypy_extensions never really went anywhere: https://github.com/python/mypy_extensions/blob/master/mypy_extensions.py#L117-L149 (we now use callback Protocols)