Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypyc] Loading type from imported modules. #18158

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

advait-dixit
Copy link
Contributor

Fixes #1075

Previously, this compiled but failed to run:

import collections
from typing_extensions import TypedDict
class C(TypedDict):
    x: collections.deque

Although type of x was being inferred correctly, it was not looking for collections.deque in imported modules.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with mypyc, but this looks good, thank you!

@hauntsaninja hauntsaninja merged commit 8ef2197 into python:master Nov 16, 2024
13 checks passed
@advait-dixit advait-dixit deleted the mypyc-fix-ann-non-ext-cls branch November 17, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypedDict from compiled module causes KeyError for certain annotations
2 participants