special case types.DynamicClassAttribute as property-like #18150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables typeshed to define types.DynamicClassAttribute as a different class from builtins.property without breakage.
This comment has been minimized.
This comment has been minimized.
JukkaL
reviewed
Nov 15, 2024
|
I added a test case which is a simplified version of the two errors that mypy-primer found when I tried to change the definition of DynamicClassAttribute in typeshed. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Nov 21, 2024
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables typeshed to define types.DynamicClassAttribute as a different class from builtins.property without breakage.
Would enable python/typeshed#12762
see also #14133
Let me know if a test case is desired for this.