Add GitHub annotations format for --output
#17771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
17612-github-annotations-output-format
branch
3 times, most recently
from
21efb22 to
70c8feb
Compare
This comment has been minimized.
This comment has been minimized.
edgarrmondragon
force-pushed
the
17612-github-annotations-output-format
branch
from
70c8feb to
b330d80
Compare
This comment has been minimized.
This comment has been minimized.
|
I assume this no longer needs to be marked as a draft? |
I've got a TODO comment in the diff that I want to address before opening the PR for review. |
edgarrmondragon
force-pushed
the
17612-github-annotations-output-format
branch
from
b330d80 to
e03e7f1
Compare
This comment has been minimized.
This comment has been minimized.
edgarrmondragon
force-pushed
the
17612-github-annotations-output-format
branch
from
b335987 to
fcdfa8f
Compare
edgarrmondragon
commented
Sep 27, 2024
Comment on lines
+42
to
+44
| ::notice file=main,line=12,col=12,title=Mypy (misc)::Revealed type is "Overload(def (), def (x: builtins.int))". | ||
| ::error file=main,line=14,col=0,title=Mypy (call-overload)::No overload variant of "foo" matches argument type "str".%0A%0APossible overload variants:%0A def foo() -> None%0A def foo(x: int) -> None | ||
| ::error file=main,line=17,col=0,title=Mypy (call-arg)::Too many arguments for "bar". |
There was a problem hiding this comment.
Here's how these look like in the diff view:
There was a problem hiding this comment.
This looks amazing! We would like to use it in our github actions! Will this PR be merged soon?
edgarrmondragon
commented
Sep 27, 2024
| @@ -530,11 +530,7 @@ def add_invertible_flag( | |||
| ) | |||
|
|
|||
| general_group.add_argument( | |||
| "-O", | |||
| "--output", | |||
| metavar="FORMAT", | |||
There was a problem hiding this comment.
This was preventing the choices from being displayed in the --help output
This comment has been minimized.
This comment has been minimized.
Seluj78
approved these changes
Sep 28, 2024
edgarrmondragon
force-pushed
the
17612-github-annotations-output-format
branch
from
fcdfa8f to
f22bffa
Compare
This comment has been minimized.
This comment has been minimized.
edgarrmondragon
force-pushed
the
17612-github-annotations-output-format
branch
from
f22bffa to
2a9c638
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: schemathesis (https://github.com/schemathesis/schemathesis)
- File "/tmp/mypy_primer/old_mypy/venv/bin/mypy", line 8, in <module>
+ File "/tmp/mypy_primer/new_mypy/venv/bin/mypy", line 8, in <module>
- File "/tmp/mypy_primer/old_mypy/venv/lib/python3.12/site-packages/mypy/__main__.py", line 15, in console_entry
+ File "/tmp/mypy_primer/new_mypy/venv/lib/python3.12/site-packages/mypy/__main__.py", line 15, in console_entry
- File "/tmp/mypy_primer/old_mypy/venv/lib/python3.12/site-packages/mypy/main.py", line 119, in main
+ File "/tmp/mypy_primer/new_mypy/venv/lib/python3.12/site-packages/mypy/main.py", line 119, in main
- File "/tmp/mypy_primer/old_mypy/venv/lib/python3.12/site-packages/mypy/main.py", line 203, in run_build
+ File "/tmp/mypy_primer/new_mypy/venv/lib/python3.12/site-packages/mypy/main.py", line 203, in run_build
- File "/tmp/mypy_primer/old_mypy/venv/lib/python3.12/site-packages/mypy/build.py", line 191, in build
+ File "/tmp/mypy_primer/new_mypy/venv/lib/python3.12/site-packages/mypy/build.py", line 191, in build
- File "/tmp/mypy_primer/old_mypy/venv/lib/python3.12/site-packages/mypy/build.py", line 267, in _build
+ File "/tmp/mypy_primer/new_mypy/venv/lib/python3.12/site-packages/mypy/build.py", line 267, in _build
- File "/tmp/mypy_primer/old_mypy/venv/lib/python3.12/site-packages/mypy/build.py", line 2947, in dispatch
+ File "/tmp/mypy_primer/new_mypy/venv/lib/python3.12/site-packages/mypy/build.py", line 2947, in dispatch
- File "/tmp/mypy_primer/old_mypy/venv/lib/python3.12/site-packages/mypy/build.py", line 976, in write_deps_cache
+ File "/tmp/mypy_primer/new_mypy/venv/lib/python3.12/site-packages/mypy/build.py", line 976, in write_deps_cache
|
|
This would be a great feature; is it likely to make its way into 1.16? |
Probably not. See #11396 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new output format as GitHub Workflow commands, aka annotations.
Refs:
Closes #17612