User defined callable (Work In Progress) #1644

margaret · 2016-06-04T02:37:32Z

Trying to fix #797

Currently debugging broken tests, specifically things like

class A(type):
    def __init__(self) -> None: pass
def f(x: type): pass
f(A())

Do not work and return
error: Argument 1 to "f" has incompatible type Callable[[Any, Any], Any]; expected "type"

- Re-raise the LookupError as a slightly more helpful DecodeError - Catch the DecodeError and raise as CompileError so the BuildManager will handle it instead of crashing.

- In cmdline.test so the file parsing happens in build.py. The tests in parse-errors.test call the parse() method in parse.py directly.

- Tests are NOT passing I think because something that checks for subtype gets builtins.function instead of the defined class

- previously was set as builtins.function because it was being created from the __call__ FuncDef

gvanrossum · 2016-09-29T21:53:21Z

I am closing this for lack of progress. Margaret, if you want to work on this again, please re-open the PR!

margaret added 5 commits June 2, 2016 16:50

Handle LookupError generated by decoding a file with an invalid encoding

3652b57

- Re-raise the LookupError as a slightly more helpful DecodeError - Catch the DecodeError and raise as CompileError so the BuildManager will handle it instead of crashing.

Add unit test to check for crashing on files with invalid encoding

b6bc4a8

- In cmdline.test so the file parsing happens in build.py. The tests in parse-errors.test call the parse() method in parse.py directly.

Merge remote-tracking branch 'upstream/master'

f908079

Class with __call__ defined is now classified as a callable

bcd8ca6

- Tests are NOT passing I think because something that checks for subtype gets builtins.function instead of the defined class

Actually set fallback of CallableType class to Instance

6a1e216

- previously was set as builtins.function because it was being created from the __call__ FuncDef

gvanrossum closed this Sep 29, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User defined callable (Work In Progress) #1644

User defined callable (Work In Progress) #1644

margaret commented Jun 4, 2016

gvanrossum commented Sep 29, 2016

User defined callable (Work In Progress) #1644

User defined callable (Work In Progress) #1644

Conversation

margaret commented Jun 4, 2016

gvanrossum commented Sep 29, 2016