Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New semantic analyser: Establish and document the defer() calling convention #7071

Closed
ilevkivskyi opened this issue Jun 26, 2019 · 0 comments · Fixed by #7159
Closed

New semantic analyser: Establish and document the defer() calling convention #7071

ilevkivskyi opened this issue Jun 26, 2019 · 0 comments · Fixed by #7159
Assignees
Labels
documentation priority-0-high semantic-analyzer Problems that happen during semantic analysis

Comments

@ilevkivskyi
Copy link
Member

(adding documentation label because it is also important for external plugin contributors)

The most important point is probably to decide on which side of anal_type() (and all other similar functions) we should call defer(). I think there are still some calls that are not needed (and may be even harmful during final iteration, note that the defer() calls in typeanal.py are correctly guarded for final iteration).

See also #6725

@ilevkivskyi ilevkivskyi added documentation priority-0-high semantic-analyzer Problems that happen during semantic analysis labels Jun 26, 2019
@JukkaL JukkaL self-assigned this Jul 2, 2019
JukkaL added a commit that referenced this issue Jul 2, 2019
Document deferral logic in some detail and remove redundant
calls to `defer()`.

Work towards #7071.
JukkaL added a commit that referenced this issue Jul 3, 2019
JukkaL added a commit that referenced this issue Jul 5, 2019
This concludes documentation that started in #7130 and #7135.

Closes #7071.
JukkaL added a commit that referenced this issue Jul 5, 2019
This concludes documentation that started in #7130 and #7135.

Closes #7071.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation priority-0-high semantic-analyzer Problems that happen during semantic analysis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants