-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] GH-96636: Remove all uses of NOTRACE_DISPATCH (GH-96643) #96688
Conversation
Co-authored-by: Brandt Bucher <[email protected]> (cherry picked from commit aa3b4cf)
Whoops this probably should wait for @pablogsal before it gets merged. |
It would be great if we can quickly check that the coverage test suite passes or doesn't fail more with this PR before landing. Otherwise, LGTM, land when ready 👍 |
This shouldn't impact coverage.py. This is for weird code that turns on tracing in finalizers, weakrefs or asynchronously. I'm fairly sure coverage.py doesn't do any of those things. @nedbat? |
Coverage.py doesn't do any of those weird things :) Also, I now have nightly build testing every day, so we'll hear soon if this broke something. |
Ok, let's merge it then 👍 |
An extra Lines 3582 to 3586 in 46f791d
|
Nice catch. I'll open a PR to fix. |
Co-authored-by: Brandt Bucher [email protected]
(cherry picked from commit aa3b4cf)
NOTRACE_DISPATCH
breaks tracing #96636