bpo-32911: Add new AST node for docstring #5927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes are not PEP 7 compliant because I've copied from old code before GH-46. |
serhiy-storchaka
approved these changes
Mar 2, 2018
Python/ast.c
Outdated
| } | ||
| } | ||
| return NULL; | ||
| return 0; |
There was a problem hiding this comment.
Functions in this file usually return 1 on success and 0 on error (except functions which need to return a non-negative index on success).
| c->u->u_lineno = st->lineno; | ||
| } | ||
| /* Every annotated class and module should have __annotations__. */ | ||
| if (find_ann(stmts)) { | ||
| ADDOP(c, SETUP_ANNOTATIONS); | ||
| } | ||
| if (!asdl_seq_LEN(stmts)) |
There was a problem hiding this comment.
Maybe move this to the bottom of this function?
There was a problem hiding this comment.
This should be before asdl_seq_GET.
And this code is copied back from 3.6. (There are extra blank line, I'll remove it)
Lines 1457 to 1459 in baa4507
Tools/parser/unparse.py
Outdated
| @@ -81,6 +79,10 @@ def _Expr(self, tree): | |||
| self.fill() | |||
| self.dispatch(tree.value) | |||
|
|
|||
| def _DocString(self, t): | |||
| self.fill() | |||
| self.write(repr(t.s)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32911