-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo #59
fix typo #59
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 82.37% 82.37% -0.01%
==========================================
Files 1427 1427
Lines 350948 350948
==========================================
- Hits 289102 289084 -18
- Misses 61846 61864 +18 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fix typos.
But two typos are from upstream project. Please fix them at upstream.
Remained three fixes are LGTM
@@ -100,7 +100,7 @@ dnl Check to see whether a particular set of modules exists. Similar to | |||
dnl PKG_CHECK_MODULES(), but does not set variables or print errors. | |||
dnl | |||
dnl Please remember that m4 expands AC_REQUIRE([PKG_PROG_PKG_CONFIG]) | |||
dnl only at the first occurence in configure.ac, so if the first place | |||
dnl only at the first occurrence in configure.ac, so if the first place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated. Don't change this file.
This typo comes from pkg.m4
in pkg-config
. Please fix it in upstream.
@@ -1638,7 +1638,7 @@ local void fill_window(s) | |||
* | |||
* deflate_stored() is written to minimize the number of times an input byte is | |||
* copied. It is most efficient with large input and output buffers, which | |||
* maximizes the opportunites to have a single copy from next_in to next_out. | |||
* maximizes the opportunities to have a single copy from next_in to next_out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is bundled. Please report the typo to zlib.
fix typo