Renamed whole Mac OS X's to macOS #58
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
Doc/library/macpath.rst
Outdated
| @@ -1,15 +1,15 @@ | |||
| :mod:`macpath` --- Mac OS 9 path manipulation functions | |||
| :mod:`macpath` --- macOS 9 path manipulation functions | |||
There was a problem hiding this comment.
@methane i think it's fine, isn't you?
There was a problem hiding this comment.
I don't know what is Apple's definition. Is there any resource from Apple?
There was a problem hiding this comment.
@methane Apple called mac OS 9 but there is no source on their website now.
There was a problem hiding this comment.
https://en.wikipedia.org/wiki/MacOS
"OS X" was renamed macOS. But no information about classic "Mac OS".
There was a problem hiding this comment.
@methane okey, I'm changing back old Mac OS's.
Doc/library/select.rst
Outdated
| @@ -516,7 +516,7 @@ https://www.freebsd.org/cgi/man.cgi?query=kqueue&sektion=2 | |||
| | :const:`KQ_FILTER_PROC` | Watch for events on a process id | | |||
| +---------------------------+---------------------------------------------+ | |||
| | :const:`KQ_FILTER_NETDEV` | Watch for events on a network device | | |||
| | | [not available on Mac OS X] | | |||
| | | [not available on macOS] | | |||
Doc/library/webbrowser.rst
Outdated
| +------------------------+-----------------------------------------+-------+ | ||
| | ``'safari'`` | :class:`MacOSX('safari')` | \(3) | | ||
| | ``'safari'`` | :class:`macOS('safari')` | \(3) | |
There was a problem hiding this comment.
@ergenekonyigit Thanks for your suggested changes. But I think we need to be more careful here. Many of these changes are incorrect and unnecessary churn. While it is OK to change generic OS references to macOS, it is not correct to refer to macOS versions prior to 10.12. See https://en.wikipedia.org/wiki/MacOS for the standard Apple designations. Also, we should not be changing references in WhatsNew documents for older releases.
Doc/library/asyncio-eventloops.rst
Outdated
| @@ -115,18 +115,18 @@ configuration. See :ref:`asyncio delayed calls <asyncio-delayed-calls>`. | |||
| :class:`ProactorEventLoop` now supports SSL. | |||
|
|
|||
|
|
|||
| Mac OS X | |||
| macOS | |||
| ^^^^^^^^ | |||
There was a problem hiding this comment.
Looks like the underline should be fixed here.
Doc/library/plistlib.rst
Outdated
| @@ -1,8 +1,8 @@ | |||
| :mod:`plistlib` --- Generate and parse Mac OS X ``.plist`` files | |||
| :mod:`plistlib` --- Generate and parse macOS ``.plist`` files | |||
| ================================================================ | |||
There was a problem hiding this comment.
Underline. There's probably a lot more instances.
|
@ned-deily https://github.com/apple/swift/blob/30dd1a90474032717332f26aca8acbfda427d8bb/test/stdlib/DispatchDeprecationMacOS.swift#L8 Before changing I'm looking in swift source code. Maybe not today but someday i think we have to change them. Look at 11 different variations, this is very complicated, what do you think? |
|
FWIW, I agree with @ned-deily. I suggest to close this PR. |
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 82.37% 82.37% -0.01%
==========================================
Files 1427 1427
Lines 350948 350948
==========================================
- Hits 289102 289094 -8
- Misses 61846 61854 +8Continue to review full report at Codecov.
|
|
I agree w/ @ned-deily and @berkerpeksag about this being unnecessary updates. While we should definitely use the proper term going forward, the docs should just be left as-is. Thanks for the PR regardless, @ergenekonyigit ! |
|
FTR, I'm not opposed to updating references in the current docs as long as they are done carefully and accurately. As @brettcannon suggests, a better way to do that is to make appropriate updates as we move forward with other, more important changes in the various areas. |
Once a core dev approved it and all CI passed.
I renamed whole different variations Mac OS X's to macOS
A few different variations I found.
Mac OS ——> macOS
Mac OS X ——> macOS
Mac OSX ——> macOS
MacOS X ——> macOS
Mac OSX ——> macOS
MacOSX ——> macOS
OSX ——> macOS
OS X ——> macOS
With this, everything about macOS can be found comfortably.