bpo-29742: asyncio get_extra_info() throws exception #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fafhrd91, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo, @1st1, @serhiy-storchaka and @vadmium to be potential reviewers. |
|
Could you please also add a NEWS entry? |
|
@1st1 do I need to create correspondent |
Yes, please! |
|
added news entry |
1st1
reviewed
Mar 6, 2017
Lib/asyncio/sslproto.py
Outdated
| return self._transport.get_extra_info(name, default) | ||
| else: | ||
| return None |
There was a problem hiding this comment.
return default, not None. Please also add a test for this.
1st1
changed the title
1st1
pushed a commit
to 1st1/cpython
that referenced
this pull request
Mar 12, 2017
1st1
pushed a commit
to 1st1/cpython
that referenced
this pull request
Mar 12, 2017
1st1
added a commit
that referenced
this pull request
Mar 12, 2017
1st1
added a commit
that referenced
this pull request
Mar 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for python/asyncio#494